Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to the then shortcut #1228

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Remove reference to the then shortcut #1228

merged 2 commits into from
Mar 14, 2023

Conversation

cescoffier
Copy link
Contributor

Fix #1224

  • Remove then from the shortcut list and from the javadoc
  • Apply the new formatter.

@cescoffier cescoffier requested a review from jponge March 13, 2023 16:13
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1228 (df34777) into main (912193f) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head df34777 differs from pull request most recent head edab212. Consider uploading reports for the commit edab212 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1228      +/-   ##
============================================
- Coverage     89.72%   89.67%   -0.06%     
- Complexity     3348     3349       +1     
============================================
  Files           458      458              
  Lines         13227    13227              
  Branches       1646     1646              
============================================
- Hits          11868    11861       -7     
- Misses          705      712       +7     
  Partials        654      654
Impacted Files Coverage Δ
...tation/src/main/java/io/smallrye/mutiny/Multi.java 94.11% <ø> (ø)
...entation/src/main/java/io/smallrye/mutiny/Uni.java 90.90% <ø> (ø)
...java/io/smallrye/mutiny/groups/MultiOnFailure.java 100.00% <ø> (ø)
...java/io/smallrye/mutiny/groups/MultiOnRequest.java 100.00% <ø> (ø)
...va/io/smallrye/mutiny/groups/MultiOnTerminate.java 100.00% <ø> (ø)
...main/java/io/smallrye/mutiny/groups/UniCreate.java 100.00% <ø> (ø)
...ain/java/io/smallrye/mutiny/groups/UniMemoize.java 100.00% <ø> (ø)
...n/java/io/smallrye/mutiny/groups/UniOnFailure.java 94.28% <ø> (ø)
...java/io/smallrye/mutiny/groups/UniOnSubscribe.java 100.00% <ø> (ø)
...smallrye/mutiny/helpers/StrictMultiSubscriber.java 100.00% <ø> (ø)
... and 6 more

... and 13 files with indirect coverage changes

@jponge jponge added the documentation Improvements or additions to documentation label Mar 13, 2023
@jponge jponge added the backport PR that shall be back-ported label Mar 13, 2023
@jponge
Copy link
Member

jponge commented Mar 13, 2023

Shall be backported

@cescoffier cescoffier merged commit 36fdfc4 into smallrye:main Mar 14, 2023
@cescoffier cescoffier deleted the remove-then branch March 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jponge jponge jponge approved these changes

Assignees
No one assigned
Labels
backport PR that shall be back-ported documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove documentation references to Uni::then
2 participants
@cescoffier @jponge